From 3609bfe68724dfff3053eb41177a769b893b2750 Mon Sep 17 00:00:00 2001 From: Albert Date: Sun, 26 Apr 2026 15:05:14 +0800 Subject: [PATCH] feat(team): add reviewer routing projection --- CLAUDE.md | 6 +- backend/app/schemas/pmflow_os.py | 21 ++ .../services/pmflow_os_projection_service.py | 169 ++++++++++++++- .../tests/test_pmflow_os_projection_api.py | 199 ++++++++++++++++++ docs/PMFLOW_PRODUCT_DELIVERY_STANDARD.md | 41 +++- docs/architecture/ARCHITECTURE_INVENTORY.md | 4 +- docs/architecture/CODE_REFERENCE_INDEX.md | 4 +- frontend/src/api/pmflowOs.ts | 20 ++ .../pmflow-os/pages/TeamLayerPage.tsx | 141 +++++++++++++ .../src/features/pmflow-os/store.api.test.tsx | 42 ++++ 10 files changed, 637 insertions(+), 10 deletions(-) diff --git a/CLAUDE.md b/CLAUDE.md index f0c855a1..a3d26bdb 100644 --- a/CLAUDE.md +++ b/CLAUDE.md @@ -113,8 +113,8 @@ frontend/ - `frontend/src/features/personal-space/`（个人空间首页；通过 `frontend/src/api/space.ts` 只读聚合项目摘要、PMFlow OS truth-state / execution-summary，承载继续推进、待确认、AI 正在推进、草案箱和最近项目入口） - `frontend/src/features/project-launch/`（首次进入页 / 新项目启动台；默认调用真实 `frontend/src/api/pmflowLaunch.ts` draft/confirm API 创建项目，只有显式 `?demo=1` 或 `?dataSource=demo` 才启用本地 mock 演示状态机） - `frontend/src/features/account-settings/`（`/me` 个人中心与设置；通过 `frontend/src/api/accountSettings.ts` 管理个人资料、默认语言、AI 回答深度、证据展示偏好和通知偏好，移动端使用分组列表与 bottom sheet，不进入 auth core） - - `frontend/src/features/pmflow-os/`（PMFlow OS 前端产品域；共享 truth store 已支持 `?projectId=` 读取真实后端 projection，真实模式下 message、`proposed_items` extraction、ChangeItem `accept/edit/defer`、ChangeSet `commit` 与 iteration recommendation -> ChangeSet draft 调后端，显式 `?demo=1` 才启用本地演示状态机） - - `backend/app/api/pmflow_os_api/` + `backend/app/services/pmflow_os_projection_service.py` + `backend/app/services/pmflow_change_review_service.py` + `backend/app/schemas/pmflow_os.py` + `backend/app/models/pmflow_change_review.py`（PMFlow OS A3/C1/C2 真实路径；提供 `truth-state`、`execution-summary`、thread message、`proposed_items` extraction、ChangeSet detail、ChangeItem `accept/edit/defer`、ChangeSet `commit`、execution handoff/progress writeback、release validation run、release feedback ingest 与 recommendation change-set draft；复用 `truth_nodes / tasks / semantic_facts / ai_project_control / dev_sync / FeedbackIngest / IterationRecommendation` 并投影 `pmflow_threads / pmflow_thread_messages / pmflow_change_sets / pmflow_change_items / pmflow_approvals / pmflow_evidence_links`；C2 commit 默认 atomic，`ModelDecision / MetricSignal` 暂 fail-closed） + - `frontend/src/features/pmflow-os/`（PMFlow OS 前端产品域；共享 truth store 已支持 `?projectId=` 读取真实后端 projection，真实模式下 message、`proposed_items` extraction、ChangeItem `accept/edit/defer`、ChangeSet `commit`、Team reviewer routing 与 iteration recommendation -> ChangeSet draft 调后端，显式 `?demo=1` 才启用本地演示状态机） + - `backend/app/api/pmflow_os_api/` + `backend/app/services/pmflow_os_projection_service.py` + `backend/app/services/pmflow_change_review_service.py` + `backend/app/schemas/pmflow_os.py` + `backend/app/models/pmflow_change_review.py`（PMFlow OS A3/C1/C2 真实路径；提供 `truth-state`、`execution-summary`、thread message、`proposed_items` extraction、ChangeSet detail、ChangeItem `accept/edit/defer`、ChangeSet `commit`、execution handoff/progress writeback、release validation run、release feedback ingest、Team reviewer routing 与 recommendation change-set draft；复用 `truth_nodes / tasks / semantic_facts / ai_project_control / dev_sync / FeedbackIngest / IterationRecommendation` 并投影 `pmflow_threads / pmflow_thread_messages / pmflow_change_sets / pmflow_change_items / pmflow_approvals / pmflow_evidence_links`；`truth-state.reviewerRouting` 只读生成建议审查人/原因/warning，不写 approval、不自动 assign reviewer；C2 commit 默认 atomic，`ModelDecision / MetricSignal` 暂 fail-closed） - `backend/app/api/pmflow_launch_api/` + `backend/app/services/pmflow_launch_service.py` + `backend/app/schemas/pmflow_launch.py` + `backend/app/models/pmflow_launch.py`（Project Launch Phase B 真实创建链；`drafts` 只写 `pmflow_launch_drafts`，`confirm` 在同一事务写真实 Project、启动线程、启动消息、初始 truth_nodes、tasks 与 semantic_facts seed） - `docs/architecture/PMFLOW_OS_PRODUCT_CONTRACT.md`（PMFlow OS 产品合同真源；真实后端接入前先读，锁定本地 truth store 对象与 `truth_nodes / tasks / semantic_facts / ai_project_control / dev_sync` 的映射；Phase C1 review 表和审查 API 已实现，Phase C2 backend/frontend commit 已实现） - `frontend/src/pages/inbox/`（消息台） @@ -134,7 +134,7 @@ frontend/ - `frontend/src/features/project-launch/` 是新项目启动台独立产品域：`types.ts / useProjectLaunchState.ts` 承载状态合同和真实 API 编排，`mockData.ts` 只在显式 demo 模式下使用；默认路径调用 `POST /pmflow-launch/drafts` 生成可审查草案，确认后调用 `POST /pmflow-launch/drafts/{draft_id}/confirm` 创建真实项目并跳转 `/pmflow-os?projectId=`。`LaunchShell` 桌面端复用 `frontend/src/features/personal-space/components/SpaceChrome.tsx` 的空间左侧栏和顶部条，主画布仍由 `IntentInputPanel / AIProgressCanvas / HumanReviewCanvas / DraftEditCanvas / FailureStatePanel / SuccessTransitionPanel` 承接，移动端仍由 `MobileLaunchLayout` 承接；`frontend/src/pages/ProjectLaunchPage.tsx` 仅做薄入口。 - `frontend/src/features/personal-space/` 是空间层入口：`PersonalSpacePage.tsx` 承接桌面个人工作面与独立移动单手布局，`frontend/src/api/space.ts` 只读聚合 `projects` summary、PMFlow OS `truth-state`、`execution-summary` 并生成继续推进、待确认、发布关注、发布后反馈关注、下一轮迭代草稿关注、AI 正在推进、草案箱、最近项目摘要；Space P3 的发布关注优先消费 `truth-state.releases` 的 release validation 投影，没有验证投影时才回落 `execution-summary.releaseGate`；Space P4/P5 的发布后反馈/下一轮草稿关注只读消费 `execution-summary.releaseSignals`，点击只跳 `/release-growth?projectId=` 或 `/change-review?projectId=&changeSetId=`；不在 Space 写 Project Memory、ProgressEvent、ReleaseValidationRun、FeedbackIngest、RevenueEvent、ComplianceCheckRun、ChangeSet 状态或发布执行。`components/SpaceChrome.tsx` 承接空间层左侧栏、顶部条与空间用量组件，并被 `/project-launch` 桌面首次新建壳复用；`frontend/src/pages/PersonalSpacePage.tsx` 仅做薄入口。 - `frontend/src/features/account-settings/` 是 Account Settings 独立产品域：`AccountSettingsPanel.tsx` 承接 `/me` 桌面设置页、移动端分组列表与 bottom sheet，`frontend/src/api/accountSettings.ts` 定义个人资料、默认语言、AI 回答深度、证据展示偏好和四类通知偏好合同；当前已有账号同步 API fallback、本地 UI 通知消费模型、Release/Growth 偏好 helper 和 post-release / next change review 偏好 helper，`releaseGate / failureAlert / pendingConfirmation` 只影响页面内提醒表达，不代表真实邮件、桌面推送或系统通知中心已接入，不改 OAuth/JWT/auth core；`frontend/src/features/pmflow-os/pages/AccountPage.tsx` 仅做薄入口并复用既有退出登录 bottom sheet。 -- `frontend/src/features/pmflow-os/` 当前承载新的对话驱动前端产品域：`store.tsx` 提供共享 truth store；真实模式通过 `?projectId=` 调用 `frontend/src/api/pmflowOs.ts` 读取后端 `ProjectTruthState` projection，并调用真实 message、`proposed_items` extraction、ChangeItem `accept/edit/defer`、ChangeSet `commit`、Execution Handoff create/consume、execution progress writeback、release validation run create、release feedback ingest 与 iteration recommendation -> ChangeSet draft API，成功后 refetch truth-state / execution-summary；显式 `?demo=1` 才启用 `command_idle -> ai_extracting -> extraction_ready -> review_open -> writeback_success` 本地演示状态机，以及本地 `promoteAcceptedToGraph` 等演示动作。`pages/` 下包含 `CommandCenter / StructuredExtraction / ChangeReview / MemoryWritebackResult / WorkGraph / ExecutionBridge / ReleaseGrowth / TeamLayer / ProjectMemory / Account` 主页面；`ExecutionBridgePage` 已支持创建 handoff、运行端领取确认和执行进度回写；`ReleaseGrowthPage` 真实模式展示 `execution-summary.releaseGate`、execution evidence、阻塞原因、下一步动作、`latestValidationRun` 和 `releaseSignals`，可创建 release validation run、摄取发布后 feedback、从真实 recommendation 生成下一轮待确认 ChangeSet draft，并消费 Account notification preference 静默强调型提醒，但不隐藏真实证据、审计状态或发布后信号；静态发布/增长原型仅保留在显式 demo 模式；后端只记录 progress/release gate/release validation/release feedback/recommendation draft 元数据，不执行本机命令、真实发布命令、外部支付、真实推送、自动 Project Memory commit 或正式任务创建；`ProjectMemoryPage` 在真实模式消费后端 `truth_nodes + semantic_facts` 的 `projectMemory` 投影，真实模式下 accepted/edited ChangeItem 只有 commit 成功后才进入 Project Memory。`components/` 下除了 `ProjectStageRail / ThreadComposer / ExtractionRail / ChangeGroupPanel / ObjectGraphSection / ContextPacketPanel / ExecutionTimeline / ReleaseGatePanel / TeamFeedPanel` 之外，新增 `ProjectStructuredLoop / PMFlowOsFrame / AccountControls / FeedbackPrimitives` 等行为组件，用来承接项目指挥台、结构化提取、待确认审查、项目记忆写入结果、项目内面包屑、项目切换器、账号退出登录交互，以及 `PageBanner / InlineNotice / HumanDecisionBar / ConfirmDialog / MobileBottomSheet` 这组契约化提示提醒组件；`components/MobileBottomNav.tsx` 是正式应用壳唯一移动底部导航，固定为 `空间 / 指挥台 / 待确认 / 动态 / 我的`。 +- `frontend/src/features/pmflow-os/` 当前承载新的对话驱动前端产品域：`store.tsx` 提供共享 truth store；真实模式通过 `?projectId=` 调用 `frontend/src/api/pmflowOs.ts` 读取后端 `ProjectTruthState` projection，并调用真实 message、`proposed_items` extraction、ChangeItem `accept/edit/defer`、ChangeSet `commit`、Execution Handoff create/consume、execution progress writeback、release validation run create、release feedback ingest 与 iteration recommendation -> ChangeSet draft API，成功后 refetch truth-state / execution-summary；显式 `?demo=1` 才启用 `command_idle -> ai_extracting -> extraction_ready -> review_open -> writeback_success` 本地演示状态机，以及本地 `promoteAcceptedToGraph` 等演示动作。`pages/` 下包含 `CommandCenter / StructuredExtraction / ChangeReview / MemoryWritebackResult / WorkGraph / ExecutionBridge / ReleaseGrowth / TeamLayer / ProjectMemory / Account` 主页面；`TeamLayerPage` 真实模式读取 `state.reviewerRouting` 展示待审 ChangeSet、建议审查人、审查原因、风险类型和缺角色 warning，动作只跳转 Change Review，不自动分派 reviewer；`ExecutionBridgePage` 已支持创建 handoff、运行端领取确认和执行进度回写；`ReleaseGrowthPage` 真实模式展示 `execution-summary.releaseGate`、execution evidence、阻塞原因、下一步动作、`latestValidationRun` 和 `releaseSignals`，可创建 release validation run、摄取发布后 feedback、从真实 recommendation 生成下一轮待确认 ChangeSet draft，并消费 Account notification preference 静默强调型提醒，但不隐藏真实证据、审计状态或发布后信号；静态发布/增长原型仅保留在显式 demo 模式；后端只记录 progress/release gate/release validation/release feedback/recommendation draft 元数据，不执行本机命令、真实发布命令、外部支付、真实推送、自动 Project Memory commit 或正式任务创建；`ProjectMemoryPage` 在真实模式消费后端 `truth_nodes + semantic_facts` 的 `projectMemory` 投影，真实模式下 accepted/edited ChangeItem 只有 commit 成功后才进入 Project Memory。`components/` 下除了 `ProjectStageRail / ThreadComposer / ExtractionRail / ChangeGroupPanel / ObjectGraphSection / ContextPacketPanel / ExecutionTimeline / ReleaseGatePanel / TeamFeedPanel` 之外，新增 `ProjectStructuredLoop / PMFlowOsFrame / AccountControls / FeedbackPrimitives` 等行为组件，用来承接项目指挥台、结构化提取、待确认审查、项目记忆写入结果、项目内面包屑、项目切换器、账号退出登录交互，以及 `PageBanner / InlineNotice / HumanDecisionBar / ConfirmDialog / MobileBottomSheet` 这组契约化提示提醒组件；`components/MobileBottomNav.tsx` 是正式应用壳唯一移动底部导航，固定为 `空间 / 指挥台 / 待确认 / 动态 / 我的`。 - 旧登录实现 `frontend/src/components/ui/sign-in.tsx` 与 `frontend/src/components/ui/demo.tsx` 已移除，`frontend/src/components/login/` 是当前唯一登录真源。 ### 5.1 `frontend/src/components/sstc/` 目录说明（模块化拆分后） diff --git a/backend/app/schemas/pmflow_os.py b/backend/app/schemas/pmflow_os.py index 395b597d..02994d93 100644 --- a/backend/app/schemas/pmflow_os.py +++ b/backend/app/schemas/pmflow_os.py @@ -276,6 +276,26 @@ class PMFlowTeamInbox(BaseModel): growth: list[str] = Field(default_factory=list) +class PMFlowReviewerSuggestion(BaseModel): + userId: str + name: str + role: str + reason: str + + +class PMFlowChangeSetReviewerRouting(BaseModel): + changeSetId: str + headline: str + summary: str + pendingItemCount: int = 0 + highestRiskLevel: PMFlowRiskLevel = "low" + riskTypes: list[str] = Field(default_factory=list) + crossDomain: bool = False + suggestedReviewers: list[PMFlowReviewerSuggestion] = Field(default_factory=list) + reviewReasons: list[str] = Field(default_factory=list) + warning: Optional[str] = None + + class PMFlowProjectMemory(BaseModel): truthNodeFacts: list[dict[str, Any]] = Field(default_factory=list) semanticFacts: list[dict[str, Any]] = Field(default_factory=list) @@ -302,6 +322,7 @@ class ProjectTruthStateProjection(BaseModel): approvals: list[dict[str, Any]] = Field(default_factory=list) feed: list[PMFlowFeedEvent] = Field(default_factory=list) teamInbox: PMFlowTeamInbox = Field(default_factory=PMFlowTeamInbox) + reviewerRouting: list[PMFlowChangeSetReviewerRouting] = Field(default_factory=list) activeChangeSetId: Optional[str] = None selectedTaskId: Optional[str] = None execution: PMFlowExecutionContext = Field(default_factory=PMFlowExecutionContext) diff --git a/backend/app/services/pmflow_os_projection_service.py b/backend/app/services/pmflow_os_projection_service.py index c57d8178..8fff0a5d 100644 --- a/backend/app/services/pmflow_os_projection_service.py +++ b/backend/app/services/pmflow_os_projection_service.py @@ -34,6 +34,7 @@ from ..models import ( Task, TruthNode, User, + UserProject, ) from ..schemas.pmflow_os import ( ExecutionSummaryProjection, @@ -98,6 +99,12 @@ class PMFlowOSProjectionService: ) review_projection = await self._load_review_projection(project_id=project_id) active_change_set_id = self._active_change_set_id(review_projection["change_sets"]) + project_members = await self._load_project_members(project=project) + reviewer_routing, reviewer_warnings = self._project_reviewer_routing( + change_sets=review_projection["change_sets"], + change_items=review_projection["change_items"], + members=project_members, + ) loop_stage = self._review_loop_stage( change_sets=review_projection["change_sets"], change_items=review_projection["change_items"], @@ -149,11 +156,12 @@ class PMFlowOSProjectionService: metric_signals=metric_signals, ), approvals=review_projection["approvals"], + reviewerRouting=reviewer_routing, activeChangeSetId=active_change_set_id, selectedTaskId=execution_summary.execution.taskId, execution=execution_summary.execution, projectMemory=memory, - projectionWarnings=warnings + execution_summary.warnings, + projectionWarnings=warnings + reviewer_warnings + execution_summary.warnings, ) async def get_execution_summary( @@ -631,6 +639,24 @@ class PMFlowOSProjectionService: ) return [(task, user) for task, user in result.all()] + async def _load_project_members(self, *, project: Project) -> list[User]: + result = await self.db.execute( + select(User) + .outerjoin(UserProject, and_(UserProject.user_id == User.id, UserProject.project_id == int(project.id))) + .where( + and_( + User.tenant_id == self.tenant_id, + or_(UserProject.project_id == int(project.id), User.id == project.owner_id), + User.is_active.is_(True), + ) + ) + .order_by(User.id.asc()) + ) + members: dict[int, User] = {} + for user in result.scalars().all(): + members[int(user.id)] = user + return list(members.values()) + async def _load_project_task(self, *, project_id: int, task_id: str) -> Task: try: normalized_task_id = int(str(task_id).strip()) @@ -1023,6 +1049,147 @@ class PMFlowOSProjectionService: "approvals": [PMFlowChangeReviewService.serialize_approval(row) for row in approval_rows], } + def _project_reviewer_routing( + self, + *, + change_sets: list[dict[str, Any]], + change_items: list[dict[str, Any]], + members: list[User], + ) -> tuple[list[dict[str, Any]], list[str]]: + items_by_set: dict[str, list[dict[str, Any]]] = {} + for item in change_items: + if item.get("status") != "pending_review": + continue + items_by_set.setdefault(str(item.get("changeSetId")), []).append(item) + + routings: list[dict[str, Any]] = [] + warnings: list[str] = [] + for change_set in change_sets: + change_set_id = str(change_set.get("id") or "") + pending_items = items_by_set.get(change_set_id, []) + if not change_set_id or not pending_items: + continue + risk_levels = [str(item.get("riskLevel") or "medium") for item in pending_items] + object_types = sorted({str(item.get("objectType") or "Unknown") for item in pending_items}) + risk_groups = sorted({str(item.get("group") or "unknown") for item in pending_items}) + highest_risk = self._highest_risk_level(risk_levels) + cross_domain = len(object_types) > 1 or len(risk_groups) > 1 + review_reasons = self._review_routing_reasons( + pending_count=len(pending_items), + highest_risk=highest_risk, + object_types=object_types, + risk_groups=risk_groups, + cross_domain=cross_domain, + ) + suggested_reviewers = self._suggest_reviewers( + members=members, + highest_risk=highest_risk, + cross_domain=cross_domain, + ) + warning = None + if not members: + warning = "项目暂无成员，无法给出 reviewer 建议。" + elif not suggested_reviewers: + warning = "项目成员中没有 OWNER / REVIEWER 角色，暂无法给出 reviewer 建议。" + if warning: + warnings.append(f"reviewer_routing_warning:{change_set_id}:{warning}") + routings.append( + { + "changeSetId": change_set_id, + "headline": str(change_set.get("headline") or "待审 ChangeSet"), + "summary": str(change_set.get("summary") or ""), + "pendingItemCount": len(pending_items), + "highestRiskLevel": highest_risk, + "riskTypes": self._risk_type_labels(object_types=object_types, risk_groups=risk_groups, highest_risk=highest_risk), + "crossDomain": cross_domain, + "suggestedReviewers": suggested_reviewers, + "reviewReasons": review_reasons, + "warning": warning, + } + ) + return routings, warnings + + @staticmethod + def _highest_risk_level(levels: list[str]) -> str: + rank = {"low": 0, "medium": 1, "high": 2} + highest = "low" + for level in levels: + normalized = str(level or "medium").lower() + if rank.get(normalized, 1) > rank[highest]: + highest = normalized + return highest + + @staticmethod + def _risk_type_labels(*, object_types: list[str], risk_groups: list[str], highest_risk: str) -> list[str]: + labels: list[str] = [] + if highest_risk == "high": + labels.append("高风险") + elif highest_risk == "medium": + labels.append("中风险") + if len(object_types) > 1: + labels.append(f"跨对象：{' / '.join(object_types)}") + if "risk" in {group.lower() for group in risk_groups}: + labels.append("风险变更") + if "decision" in {group.lower() for group in risk_groups}: + labels.append("决策变更") + return labels or ["常规审查"] + + @staticmethod + def _review_routing_reasons( + *, + pending_count: int, + highest_risk: str, + object_types: list[str], + risk_groups: list[str], + cross_domain: bool, + ) -> list[str]: + reasons = [f"{pending_count} 个变更项仍处于待审状态。"] + if highest_risk == "high": + reasons.append("包含 high risk 变更，需要 REVIEWER 或 OWNER 复核。") + if cross_domain: + reasons.append(f"变更跨越 {' / '.join(object_types)}，需要项目 owner 统一审查口径。") + if "risk" in {group.lower() for group in risk_groups}: + reasons.append("包含风险类变更，审查时需要确认缓解策略是否足够。") + if "decision" in {group.lower() for group in risk_groups}: + reasons.append("包含决策类变更，审查时需要确认拍板依据。") + return reasons + + @staticmethod + def _suggest_reviewers( + *, + members: list[User], + highest_risk: str, + cross_domain: bool, + ) -> list[dict[str, str]]: + suggestions: list[dict[str, str]] = [] + seen: set[int] = set() + + def add(user: User, reason: str) -> None: + user_id = int(user.id) + if user_id in seen: + return + seen.add(user_id) + suggestions.append( + { + "userId": str(user.id), + "name": user.name or user.username or f"User#{user.id}", + "role": str(user.role or "MEMBER"), + "reason": reason, + } + ) + + reviewers = [user for user in members if str(user.role or "").upper() == "REVIEWER"] + owners = [user for user in members if str(user.role or "").upper() == "OWNER"] + if highest_risk == "high": + for user in reviewers: + add(user, "REVIEWER 角色，优先复核 high risk 变更。") + if cross_domain: + for user in owners: + add(user, "项目 OWNER，适合统一跨对象变更审查口径。") + for user in reviewers + owners: + add(user, "具备 OWNER / REVIEWER 审查角色，可作为本轮变更审查人。") + return suggestions[:3] + @staticmethod def _active_change_set_id(change_sets: list[dict[str, Any]]) -> Optional[str]: for row in change_sets: diff --git a/backend/tests/test_pmflow_os_projection_api.py b/backend/tests/test_pmflow_os_projection_api.py index ef328b11..2a74f6d1 100644 --- a/backend/tests/test_pmflow_os_projection_api.py +++ b/backend/tests/test_pmflow_os_projection_api.py @@ -1112,6 +1112,205 @@ async def test_iteration_recommendation_creates_reusable_changeset_draft(db_env) assert tasks == [] +@pytest.mark.asyncio +async def test_truth_state_projects_reviewer_routing_for_pending_changesets(db_env) -> None: + session = db_env + user, project = await _seed_user_project(session) + reviewer = User( + tenant_id=1, + username="reviewer", + email="reviewer@example.com", + password_hash="hashed", + name="审查负责人", + role="REVIEWER", + assigned_domains=[], + workload=0, + status="active", + is_active=True, + ) + owner = User( + tenant_id=1, + username="project-owner", + email="project-owner@example.com", + password_hash="hashed", + name="项目 Owner", + role="OWNER", + assigned_domains=[], + workload=0, + status="active", + is_active=True, + ) + session.add_all([reviewer, owner]) + await session.flush() + session.add_all( + [ + UserProject(tenant_id=1, user_id=reviewer.id, project_id=project.id), + UserProject(tenant_id=1, user_id=owner.id, project_id=project.id), + ] + ) + thread = PMFlowThread( + tenant_id=1, + project_id=project.id, + title="审查线程", + objective="验证 reviewer routing", + status="active", + source="project_launch", + ) + session.add(thread) + await session.flush() + message = PMFlowThreadMessage( + tenant_id=1, + thread_id=thread.id, + project_id=project.id, + role="user", + content="本轮包含高风险和跨对象变更。", + source="web", + attachments=[], + message_metadata={}, + status="sent", + ) + session.add(message) + await session.flush() + change_set = PMFlowChangeSet( + tenant_id=1, + project_id=project.id, + thread_id=thread.id, + source_message_id=message.id, + status="open", + summary="高风险跨域变更待审", + headline="跨域高风险 ChangeSet", + extraction_scope="latest_message", + routing_meta={}, + created_by=user.id, + ) + session.add(change_set) + await session.flush() + session.add_all( + [ + PMFlowChangeItem( + tenant_id=1, + change_set_id=change_set.id, + project_id=project.id, + group="risk", + object_type="Risk", + object_id=None, + title="新增风险：权限收敛失败", + summary="需要审查权限和数据暴露风险。", + diff="新增 high risk。", + payload={}, + confidence=0.92, + risk_level="high", + status="pending_review", + ), + PMFlowChangeItem( + tenant_id=1, + change_set_id=change_set.id, + project_id=project.id, + group="field_update", + object_type="Task", + object_id=None, + title="更新任务：补审查口径", + summary="任务验收增加 review gate。", + diff="更新验收标准。", + payload={}, + confidence=0.86, + risk_level="medium", + status="pending_review", + ), + ] + ) + await session.commit() + app = _build_app(session, SimpleNamespace(id=user.id, tenant_id=1, role="MEMBER")) + + async with AsyncClient(transport=ASGITransport(app=app), base_url="http://test") as client: + response = await client.get(f"/pmflow-os/projects/{project.id}/truth-state") + + assert response.status_code == 200 + payload = response.json()["data"] + routing = payload["reviewerRouting"][0] + assert routing["changeSetId"] == str(change_set.id) + assert routing["pendingItemCount"] == 2 + assert routing["highestRiskLevel"] == "high" + assert routing["crossDomain"] is True + assert "高风险" in routing["riskTypes"] + assert {item["role"] for item in routing["suggestedReviewers"]} == {"REVIEWER", "OWNER"} + assert any("high risk" in reason for reason in routing["reviewReasons"]) + assert payload["approvals"] == [] + assert not any("reviewer_routing_warning" in warning for warning in payload["projectionWarnings"]) + + +@pytest.mark.asyncio +async def test_truth_state_reviewer_routing_warns_without_owner_or_reviewer_role(db_env) -> None: + session = db_env + user, project = await _seed_user_project(session) + thread = PMFlowThread( + tenant_id=1, + project_id=project.id, + title="审查线程", + objective="验证 reviewer routing warning", + status="active", + source="project_launch", + ) + session.add(thread) + await session.flush() + message = PMFlowThreadMessage( + tenant_id=1, + thread_id=thread.id, + project_id=project.id, + role="user", + content="本轮缺少审查角色。", + source="web", + attachments=[], + message_metadata={}, + status="sent", + ) + session.add(message) + await session.flush() + change_set = PMFlowChangeSet( + tenant_id=1, + project_id=project.id, + thread_id=thread.id, + source_message_id=message.id, + status="open", + summary="缺少 reviewer", + headline="待审但无审查角色", + extraction_scope="latest_message", + routing_meta={}, + created_by=user.id, + ) + session.add(change_set) + await session.flush() + session.add( + PMFlowChangeItem( + tenant_id=1, + change_set_id=change_set.id, + project_id=project.id, + group="risk", + object_type="Risk", + object_id=None, + title="新增风险：缺少审查角色", + summary="应提示 warning，不虚构 reviewer。", + diff="新增 high risk。", + payload={}, + confidence=0.92, + risk_level="high", + status="pending_review", + ) + ) + await session.commit() + app = _build_app(session, SimpleNamespace(id=user.id, tenant_id=1, role="MEMBER")) + + async with AsyncClient(transport=ASGITransport(app=app), base_url="http://test") as client: + response = await client.get(f"/pmflow-os/projects/{project.id}/truth-state") + + assert response.status_code == 200 + payload = response.json()["data"] + routing = payload["reviewerRouting"][0] + assert routing["suggestedReviewers"] == [] + assert "没有 OWNER / REVIEWER" in routing["warning"] + assert any("reviewer_routing_warning" in warning for warning in payload["projectionWarnings"]) + + @pytest.mark.asyncio async def test_execution_progress_writeback_rejects_repo_outside_project(db_env) -> None: session = db_env diff --git a/docs/PMFLOW_PRODUCT_DELIVERY_STANDARD.md b/docs/PMFLOW_PRODUCT_DELIVERY_STANDARD.md index 289070f9..2bbd0cd4 100644 --- a/docs/PMFLOW_PRODUCT_DELIVERY_STANDARD.md +++ b/docs/PMFLOW_PRODUCT_DELIVERY_STANDARD.md @@ -87,7 +87,7 @@ 4. `ChangeReview` 的接受、修改、暂缓还没有写入正式对象、审批记录和证据链。 5. `ExecutionBridge` 页面还没有消费 dev-sync / GitHub / PromptPackage 真实接口。 6. `ReleaseGrowth` 已接入 execution evidence gate、release validation run 与 feedback ingest；revenue、ROI、compliance 还没有串成完整发布后反馈循环。 -7. `TeamLayer` 仍是产品表达层，缺少真实成员角色、Role Inbox、Decision Desk、Team Feed 的数据模型和审查流程。 +7. `TeamLayer` 已接入 reviewer routing 读模型，能展示待审 ChangeSet、建议审查人、审查原因、风险类型和缺角色 warning；Role Inbox、Decision Desk、Team Feed 仍缺完整真实数据模型。 ## 2. 下一步推进方向 @@ -299,7 +299,7 @@ 验收： - 不同角色看到不同待处理项。 -- 高风险 ChangeSet 能指定 reviewer/owner。 +- 高风险 ChangeSet 能先展示建议 reviewer/owner 与审查原因；自动指定或权限化分派不属于当前最小闭环。 - Team Feed 展示 AI 提取、人工确认、执行回写、测试/发布变化。 ## 4. 单次任务范围标准 @@ -807,6 +807,43 @@ P0 公共壳冻结已完成，下一批可以进入 `Batch P1` 三模块并行 ## 8. 进度台账 +### 2026-04-26 / team-review-p1-change-review-routing / done + +完成内容： + +- 在 `ProjectTruthState` 新增 `reviewerRouting` 只读投影，从 open/pending ChangeSet、待审 change item 风险、跨对象类型、项目成员与 `OWNER / REVIEWER` 角色生成建议审查人、审查原因、风险类型和 warning。 +- `TeamLayerPage` 真实模式展示待审 ChangeSet reviewer routing：待审数量、建议审查人、审查原因、风险类型、缺角色 warning，并提供跳转 Change Review 的动作。 +- 保持监督式边界：不新增 route，不新增 migration，不做复杂权限系统，不自动 assign reviewer，不写 approval；缺成员或缺 `OWNER / REVIEWER` 角色时只显示 warning，不虚构 reviewer。 +- 同步 `CLAUDE.md`、`CODE_REFERENCE_INDEX.md`、`ARCHITECTURE_INVENTORY.md` 与本台账。 + +涉及文件： + +- `backend/app/schemas/pmflow_os.py` +- `backend/app/services/pmflow_os_projection_service.py` +- `backend/tests/test_pmflow_os_projection_api.py` +- `frontend/src/api/pmflowOs.ts` +- `frontend/src/features/pmflow-os/pages/TeamLayerPage.tsx` +- `frontend/src/features/pmflow-os/store.api.test.tsx` +- `CLAUDE.md` +- `docs/PMFLOW_PRODUCT_DELIVERY_STANDARD.md` +- `docs/architecture/CODE_REFERENCE_INDEX.md` +- `docs/architecture/ARCHITECTURE_INVENTORY.md` + +验证： + +- `PYTHONPATH=backend /opt/homebrew/bin/python3.11 -m py_compile backend/app/services/pmflow_os_projection_service.py backend/app/schemas/pmflow_os.py` 通过。 +- `PYTHONPATH=backend /opt/homebrew/bin/python3.11 -m pytest backend/tests/test_pmflow_os_projection_api.py -q` 通过：`21 passed`；仍有既有 `backend/app/schemas/recipe.py` Pydantic V2 class-based config deprecation warning。 +- `cd frontend && npm run test -- src/features/pmflow-os` 通过：`10 passed`；仍有既有 React Router v7 future flag warning。 +- `cd frontend && npm run typecheck` 通过。 +- `cd frontend && npm run build` 通过；Vite 仍提示既有 manual chunk circular warning（`ai-steward / sstc / charts / governance` chunk 环）。 +- `docker compose restart backend` 已执行，`docker compose ps backend` 确认 `pmflow-backend` 恢复 `healthy`。 +- `git diff --name-only` 已执行，diff 均在本 Packet write scope 内。 + +未完成或风险： + +- 当前只是 reviewer routing 读模型与 TeamLayer 展示，不代表正式 reviewer assignment、权限审批流、通知或自动审查任务已接入。 +- Role Inbox、Decision Desk、Team Feed 的完整真实数据模型仍是后续 Team lane 工作。 + ### 2026-04-26 / big-module-integration-p6 / done 完成内容： diff --git a/docs/architecture/ARCHITECTURE_INVENTORY.md b/docs/architecture/ARCHITECTURE_INVENTORY.md index a36c4510..d755f7b2 100644 --- a/docs/architecture/ARCHITECTURE_INVENTORY.md +++ b/docs/architecture/ARCHITECTURE_INVENTORY.md @@ -193,13 +193,13 @@ - `frontend/src/components/ai-steward/QAResponseMetaCard.test.tsx` - AI Steward 问答浮窗现分三层显性化：`FloatingQAChat.tsx` 负责即时回答/历史回放归一化，`QAConversationStatusBar.tsx` 展示对象/来源/仓库/执行通道/plan handoff，`QAResponseMetaCard.tsx` 展示 `fit_brief / external_recommendation / recommended_next_step`，对应前端回归由 `FloatingQAChat.test.tsx` 与 `QAResponseMetaCard.test.tsx` 锁定。 - 登录页与营销页仍共享 `frontend/src/components/marketing/` 的部分视觉基线；公开登录页现改由 `frontend/src/components/login/` 目录承载，其中 `LoginExperience.tsx` 负责登录壳层、`LoginWorkflowVisual.tsx` 负责左侧场景、`loginScene.ts` / `loginMath.ts` 拆出展示配置与路径几何、`login.css` 负责登录页专属样式边界，`frontend/src/pages/login/LoginPage.tsx` 继续负责真实鉴权、错误态和 redirect 提示；未登录访问 `/` 会经 `frontend/src/router/index.tsx` 直接重定向到 `/login`，无显式 `redirect` 的成功登录现在默认进入 `/command-center`。 -- 前端主包治理已切到“同步首屏最小集 + route/page-section lazy”模式：`frontend/src/router/index.tsx` 保留 `LoginPage / Layout` 这组同步入口，其余后台重页面通过 `React.lazy + Suspense` 懒加载；统一 fallback 在 `frontend/src/components/layout/LazyBoundary.tsx`。P0 公共壳冻结后，大模块 route 归属为：`/space` 归 Space lane，`/project-launch` 是启动层入口，`/pmflow-os` 与 `/command-center / /change-review / /execution-bridge / /release-growth` 归 Main Flow lane，`/me` 归 Account Settings lane，`/settings` 当前仅为 reserved route、尚未实现，新增必须由 Shell / Integration owner 串行处理。`frontend/src/features/personal-space/` 作为空间层入口，通过 `/space` 提供可直接打开的本地预览入口，承载继续推进、待我确认、AI 正在推进、暂存想法、草案箱与新建项目入口。`frontend/src/features/project-launch/` 作为首次进入页 / 新项目启动台产品域，通过 `/project-launch` 提供可直接打开的入口；Phase B 后默认调用真实 `pmflow-launch` draft/confirm API，创建成功态主动作跳转后端返回的 `/pmflow-os?projectId=`，只有显式 `?demo=1` 或 `?dataSource=demo` 才启用本地 mock 状态机。`frontend/src/features/account-settings/` 作为 Account Settings 产品域，通过 `/me` 提供个人资料、默认语言、AI 回答深度、证据展示偏好、待确认/执行回写/发布门禁/失败提醒通知偏好和账户操作入口；该域通过 `frontend/src/api/accountSettings.ts` 建立前端合同，有 token 时优先调用已挂入 `backend/app/api/router.py` 的 `backend/app/api/account_settings_api/` `GET /account-settings/me` / `PUT /account-settings/me` 同步当前账号偏好，后端不可用时明确回落本机暂存，不修改 OAuth/JWT/auth core。`frontend/src/features/pmflow-os/` 作为新产品域，通过 `PMFlowOsProvider` 在应用根部挂载共享 truth store，并提供 `CommandCenter / ChangeReview / WorkGraph / ExecutionBridge / ReleaseGrowth / TeamLayer / ProjectMemory / Account` 主入口；当前 PMFlow OS 页面已切到专属轻壳，桌面端默认隐藏旧 TopBar，并由 `frontend/src/features/pmflow-os/components/PMFlowOsFrame.tsx` 统一承接“左侧稳定导航 + 顶部上下文条 + 中央视图 + 右侧 AI 副驾”的全局骨架，同时承接项目内 `个人空间 / 当前项目名` 面包屑和项目切换器；账号退出登录由 `frontend/src/features/pmflow-os/components/AccountControls.tsx` 统一承接桌面头像下拉、退出确认与移动端 bottom sheet，`frontend/src/features/pmflow-os/pages/AccountPage.tsx` 提供 `/me` 入口并委托 Account Settings 域渲染设置页；正式应用壳移动端底部导航统一由 `frontend/src/features/pmflow-os/components/MobileBottomNav.tsx` 承接，固定为 `空间 / 指挥台 / 待确认 / 动态 / 我的`，其中 `动态` 当前仍是 `/command-center` 占位。`/command-center` 额外提供免登录产品预览壳，`/pmflow-os` 是真实项目上下文 alias。主视觉按 `#2463EB + 白色` 的 Linear-like 高密度原型展开。`UsersPage` 把创建/删除/重置/导入/批量分配对话框拆为按需 chunk，`UserSkillsPage` 与 `WorkloadDetailPage` 的图表也分别拆到了 `frontend/src/pages/user-skills/components/UserSkillsRadarPanel.tsx` 与 `frontend/src/pages/workload-detail/components/WorkloadTrendChart.tsx`。 +- 前端主包治理已切到“同步首屏最小集 + route/page-section lazy”模式：`frontend/src/router/index.tsx` 保留 `LoginPage / Layout` 这组同步入口，其余后台重页面通过 `React.lazy + Suspense` 懒加载；统一 fallback 在 `frontend/src/components/layout/LazyBoundary.tsx`。P0 公共壳冻结后，大模块 route 归属为：`/space` 归 Space lane，`/project-launch` 是启动层入口，`/pmflow-os` 与 `/command-center / /change-review / /execution-bridge / /release-growth` 归 Main Flow lane，`/me` 归 Account Settings lane，`/settings` 当前仅为 reserved route、尚未实现，新增必须由 Shell / Integration owner 串行处理。`frontend/src/features/personal-space/` 作为空间层入口，通过 `/space` 提供可直接打开的本地预览入口，承载继续推进、待我确认、AI 正在推进、暂存想法、草案箱与新建项目入口。`frontend/src/features/project-launch/` 作为首次进入页 / 新项目启动台产品域，通过 `/project-launch` 提供可直接打开的入口；Phase B 后默认调用真实 `pmflow-launch` draft/confirm API，创建成功态主动作跳转后端返回的 `/pmflow-os?projectId=`，只有显式 `?demo=1` 或 `?dataSource=demo` 才启用本地 mock 状态机。`frontend/src/features/account-settings/` 作为 Account Settings 产品域，通过 `/me` 提供个人资料、默认语言、AI 回答深度、证据展示偏好、待确认/执行回写/发布门禁/失败提醒通知偏好和账户操作入口；该域通过 `frontend/src/api/accountSettings.ts` 建立前端合同，有 token 时优先调用已挂入 `backend/app/api/router.py` 的 `backend/app/api/account_settings_api/` `GET /account-settings/me` / `PUT /account-settings/me` 同步当前账号偏好，后端不可用时明确回落本机暂存，不修改 OAuth/JWT/auth core。`frontend/src/features/pmflow-os/` 作为新产品域，通过 `PMFlowOsProvider` 在应用根部挂载共享 truth store，并提供 `CommandCenter / ChangeReview / WorkGraph / ExecutionBridge / ReleaseGrowth / TeamLayer / ProjectMemory / Account` 主入口；当前 PMFlow OS 页面已切到专属轻壳，桌面端默认隐藏旧 TopBar，并由 `frontend/src/features/pmflow-os/components/PMFlowOsFrame.tsx` 统一承接“左侧稳定导航 + 顶部上下文条 + 中央视图 + 右侧 AI 副驾”的全局骨架，同时承接项目内 `个人空间 / 当前项目名` 面包屑和项目切换器；`TeamLayerPage.tsx` 现在消费 `ProjectTruthState.reviewerRouting` 展示待审 ChangeSet、建议审查人、审查原因、风险类型和缺角色 warning，动作只跳 Change Review，不自动 assign reviewer；账号退出登录由 `frontend/src/features/pmflow-os/components/AccountControls.tsx` 统一承接桌面头像下拉、退出确认与移动端 bottom sheet，`frontend/src/features/pmflow-os/pages/AccountPage.tsx` 提供 `/me` 入口并委托 Account Settings 域渲染设置页；正式应用壳移动端底部导航统一由 `frontend/src/features/pmflow-os/components/MobileBottomNav.tsx` 承接，固定为 `空间 / 指挥台 / 待确认 / 动态 / 我的`，其中 `动态` 当前仍是 `/command-center` 占位。`/command-center` 额外提供免登录产品预览壳，`/pmflow-os` 是真实项目上下文 alias。主视觉按 `#2463EB + 白色` 的 Linear-like 高密度原型展开。`UsersPage` 把创建/删除/重置/导入/批量分配对话框拆为按需 chunk，`UserSkillsPage` 与 `WorkloadDetailPage` 的图表也分别拆到了 `frontend/src/pages/user-skills/components/UserSkillsRadarPanel.tsx` 与 `frontend/src/pages/workload-detail/components/WorkloadTrendChart.tsx`。 - `frontend/src/features/personal-space/PersonalSpacePage.tsx` 是空间首页视图层，`frontend/src/api/space.ts` 是空间工作面只读聚合 API：从 `projects` summary、PMFlow OS `truth-state` 与 `execution-summary` 生成继续推进、待确认、发布关注、发布后反馈关注、下一轮迭代草稿关注、执行中 / AI 正在推进、暂存想法、草案箱、最近项目摘要；Space P3 的 `releaseAttention` 优先消费 `truth-state.releases` 中由 release validation run 投影出的 release 状态与检查项，把“发布验证阻塞 / 发布验证待确认”显示到 `/space`，没有发布验证投影时才回落到 `execution-summary.releaseGate` 的发布候选或发布门禁阻塞；Space P4/P5 的 `feedbackAttention` 只读消费 `execution-summary.releaseSignals`，把发布后 feedback、revenue、ROI、compliance、iteration recommendation 与已生成的下一轮 ChangeSet draft 关注项显示到 `/space`。发布验证、发布后信号或下一轮 draft 缺失时显示明确空态，不虚构验证、反馈、收入、ROI、合规、建议或 ChangeSet draft 结果。项目主动作进入 `/pmflow-os?projectId=`，待确认项进入 `/change-review?projectId=&changeSetId=`，发布关注和发布后反馈关注项进入 `/release-growth?projectId=`，下一轮 draft 关注项进入 `/change-review?projectId=&changeSetId=`，执行中项进入 `/execution-bridge?projectId=`；暂存想法后端只读聚合尚未接入时只显示 empty/warning，不使用 mock 数据冒充真实内容；移动端为空间首页独立 App 布局，不直接压缩桌面卡片，并保留最近项目区块；`frontend/src/pages/PersonalSpacePage.tsx` 是薄入口。该域只表达个人空间和主流程导航，不做团队空间强切换、企业组织管理、Project Memory 写入、ChangeSet 状态写入、ProgressEvent 写入、ReleaseValidationRun 写入、FeedbackIngest 写入或发布执行。 - `frontend/src/features/project-launch/types.ts`、`mockData.ts`、`useProjectLaunchState.ts` 是新项目启动台状态层；默认真实模式通过 `frontend/src/api/pmflowLaunch.ts` 生成草案并确认创建真实项目，API 失败进入明确失败态，不静默 fallback 成 mock 成功；`mockData.ts` 仅在显式 `?demo=1` 或 `?dataSource=demo` 下作为演示状态机使用。`components/LaunchShell.tsx` 负责桌面/移动分流，桌面端复用 `frontend/src/features/personal-space/components/SpaceChrome.tsx` 的空间左侧栏和顶部条，`LaunchCanvases.tsx` 和 `MobileLaunchLayout.tsx` 承接高保真图中的意图输入、AI 工作、人类确认、草案修改、生成失败、创建成功过渡与移动端 bottom sheet 交互。 - `frontend/src/features/account-settings/AccountSettingsPanel.tsx` 是 `/me` 设置页实现：桌面端为个人资料摘要 + 分区设置面板，移动端为分组列表 + `MobileBottomSheet` 编辑；当前覆盖个人资料、默认语言、AI 回答深度、证据展示偏好、待确认、执行回写、发布门禁和失败提醒通知偏好，并在通知偏好区展示页面内提醒消费说明。`frontend/src/api/accountSettings.ts` 是前端合同层；有 token 时优先调用 `backend/app/api/account_settings_api/`，失败时回落浏览器本机暂存；P2 新增 `shouldShowAccountNotification` 与 `getAccountNotificationConsumption`，将四类通知偏好映射为本地 UI 的待确认、Execution Bridge、Release/Growth 和失败提醒显示/静默状态；P3 新增 `getReleaseGateNotificationPreference(settings, event)`，把 Release/Growth 的 `release_gate_* / release_validation_*` 事件映射到 `releaseGate` 偏好，把 `failed_event` 映射到 `failureAlert` 偏好；P5/P6 的 `getPostReleaseNotificationPreference(settings, event)` 把发布后 `feedback_received / revenue_signal / compliance_blocked` 映射到 `releaseGate` 偏好，把 `iteration_recommendation / next_change_review` 映射到 `pendingConfirmation` 偏好和 `change_review` surface，并返回 `spaceReadable / evidencePolicy / reminderPolicy` 供 Main Flow 与 Space 消费。该合同只控制页面内提醒表达，不代表邮件、桌面推送或系统通知中心已接入；偏好关闭也不得隐藏业务证据、recommendation 或 ChangeSet。`backend/app/schemas/account_settings.py` 定义账号偏好合同，`backend/app/services/account_settings_service.py` 当前复用既有 `integrations` 表按 `tenant_id + user_id` 保存 `account_settings_preferences` 配置包，`backend/app/api/router.py` 已挂载该 API；未改用户表、OAuth/JWT/auth core 或 PMFlow OS truth store。 - `frontend/src/features/pmflow-os/store.tsx` 当前是 PMFlow OS 共享 truth store：`?projectId=` 时通过 React Query 调用 `frontend/src/api/pmflowOs.ts` 读取真实 `GET /pmflow-os/projects/{project_id}/truth-state` 与 `GET /pmflow-os/projects/{project_id}/execution-summary`，真实模式下项目内 message、`proposed_items` extraction、ChangeItem `accept/edit/defer`、ChangeSet commit、Execution Handoff create/consume、execution progress writeback、release validation run create、release feedback ingest 与 iteration recommendation -> ChangeSet draft 均调用 `/pmflow-os` 后端并 refetch；只有显式 `?demo=1` 或 `?dataSource=demo` 时才启用本地 mock 演示状态机。真实读取/动作失败会进入错误/空态，不静默 fallback 成 mock 成功。 - `frontend/src/features/pmflow-os/store.tsx` 仍保留演示用项目内 AI 结构化闭环状态机：`command_idle / ai_extracting / extraction_ready / review_open / writeback_success`。`frontend/src/features/pmflow-os/pages/StructuredExtractionPage.tsx` 是本轮结构化提取页，`ChangeReviewPage.tsx` 是决策与待确认中心，`MemoryWritebackResultPage.tsx` 是项目记忆写入结果页，`WorkGraphPage.tsx` 是项目工作台关系总览与对象投影视图，`ExecutionBridgePage.tsx` 是执行桥上下文包、交接按钮、运行端领取确认、PR/测试与回写状态页；`ReleaseGrowthPage.tsx` 真实模式读取 `execution-summary.releaseGate`、`latestValidationRun` 与 `releaseSignals`，从 branch、commit、PR、test、failed evidence 展示 `可发布 / 阻塞 / 需要人工确认 / 缺少证据` 判断、阻塞原因、下一步动作、发布验证记录和发布后 feedback/revenue/recommendation 信号，缺少发布后信号时显示 empty/warning，不执行发布命令、不展示 mock 发布结果；页面可把真实 recommendation 生成下一轮待确认 ChangeSet draft，生成后仍进入 Change Review accept/edit/defer，不自动 commit、不写 Project Memory、不创建正式任务；同时读取 Account notification preference helper，用 `releaseGate` 偏好控制发布门禁强调提醒，用 `failureAlert` 偏好控制失败强调提醒，偏好关闭时只静默提醒表达强度，不隐藏 release evidence、阻塞原因、审计状态、validation run 或 releaseSignals；静态发布/增长原型只保留在显式 demo 模式。A3 已接入后端 truth-state，C1 已接入真实 message/extraction/review 状态机，C2 已接入真实 ChangeSet commit，Phase D 已接入真实 execution-summary/dev-sync，D.2 已接入 `POST /execution-handoffs` 创建 PromptPackage + handoff_created progress event，P1 已接入 `POST /execution-handoffs/{prompt_package_id}/consume` 创建 handoff_consumed progress event 并把 execution status 投影为 coding，Release Growth P1 已接入 execution evidence gate，Release Validation P1 已接入 `POST /release-validation-runs` 创建 `ReleaseValidationRun` 快照，Release Feedback P1 已接入 `POST /release-feedback-ingests` 写入 `FeedbackIngest` 并生成 `IterationRecommendation`，Iteration Loop P1 已接入 `POST /iteration-recommendations/{recommendation_id}/change-set-drafts` 把 recommendation 回流到 Change Review；当前仍不调用真实 AI 提取，不把 mock 当真实失败 fallback。`ProjectMemoryPage.tsx` 在真实模式下展示后端 `truth_nodes + semantic_facts` 的 `projectMemory` 投影，accepted/edited ChangeItem 只有 commit 成功后才进入 Project Memory。`frontend/src/features/pmflow-os/components/ProjectStructuredLoop.tsx` 提供 `StatusLabel / EvidenceSnippet / ObjectChangeCard / ProjectConversationPanel / StructuredExtractionPanel / ProjectAICopilotPanel` 等闭环组件，并复用契约化 `InlineNotice` 表达“未确认不得写入”的局部提示。 -- PMFlow OS 后端入口位于 `backend/app/api/pmflow_os_api/`，projection service 位于 `backend/app/services/pmflow_os_projection_service.py`，Change Review / commit 服务位于 `backend/app/services/pmflow_change_review_service.py`，Pydantic 合同位于 `backend/app/schemas/pmflow_os.py`；当前聚合 `truth_nodes / tasks / semantic_facts / ai_project_control / dev_sync`，`Thread / Message` 来自 `pmflow_threads / pmflow_thread_messages`，`ChangeSet / ChangeItem / Approval / EvidenceLink` 来自 `backend/app/models/pmflow_change_review.py` 对应真实表。C1 已实现 message、`proposed_items` extraction、ChangeSet detail、ChangeItem `accept/edit/defer`；C2 backend/frontend 已实现 `POST /pmflow-os/change-sets/{change_set_id}/commit` 与真实模式前端接入，默认 atomic，将 `Requirement / Decision / Risk` 写入 `truth_nodes`，将 `Task` 写入 `truth_nodes(node_type='task') + tasks`，高风险项强制 approval gate；D.2 已实现 `POST /pmflow-os/projects/{project_id}/execution-handoffs`，校验 task/repo project 边界，生成/复用 `PromptPackage(package_kind='execution_handoff')` 并写 `ProgressEvent(event_type='handoff_created')` 起点；P1 已实现 `POST /pmflow-os/projects/{project_id}/execution-handoffs/{prompt_package_id}/consume`，校验 execution handoff package 后更新 `PromptPackage.package_payload.latest_handoff.handoff_state=consumed` 并写 `ProgressEvent(event_type='handoff_consumed', derived_task_status='coding')`；Release Growth P1 在 `ExecutionSummaryProjection.releaseGate` 中从 `ProgressEvent` 推导发布门禁状态，失败事件 fail-closed 阻塞发布，无证据返回 empty/warning；Release Validation P1 新增 `POST /pmflow-os/projects/{project_id}/release-validation-runs`，复用现有 `ReleaseValidationRun` 模型固化当前 `releaseGate` 快照、人工决策、证据、阻塞原因和下一步动作，并在 `releaseGate.latestValidationRun` 返回最新记录；Release Feedback P1 新增 `POST /pmflow-os/projects/{project_id}/release-feedback-ingests`，复用现有 `FeedbackIngest / IterationRecommendation`，在 `ExecutionSummaryProjection.releaseSignals` 中返回真实发布后 feedback、revenue event 和 iteration recommendation 读模型；Iteration Loop P1 新增 `POST /pmflow-os/projects/{project_id}/iteration-recommendations/{recommendation_id}/change-set-drafts`，把真实 recommendation 转为 open ChangeSet、pending_review Requirement/Task/Risk/Decision items 与 `iteration_recommendation` evidence，重复调用复用既有 draft 并在 `releaseSignals` 标记 `changeSetCreated/changeSetId`；这些步骤都不直接执行本机命令、真实发布命令、外部支付、真实推送、自动 Project Memory commit 或正式任务创建；`ModelDecision / MetricSignal` 在 C2 V1 仍 fail-closed。 +- PMFlow OS 后端入口位于 `backend/app/api/pmflow_os_api/`，projection service 位于 `backend/app/services/pmflow_os_projection_service.py`，Change Review / commit 服务位于 `backend/app/services/pmflow_change_review_service.py`，Pydantic 合同位于 `backend/app/schemas/pmflow_os.py`；当前聚合 `truth_nodes / tasks / semantic_facts / ai_project_control / dev_sync`，`Thread / Message` 来自 `pmflow_threads / pmflow_thread_messages`，`ChangeSet / ChangeItem / Approval / EvidenceLink` 来自 `backend/app/models/pmflow_change_review.py` 对应真实表。`ProjectTruthState.reviewerRouting` 是 Team layer 的 reviewer routing 读模型：从 open/pending ChangeSet、待审 item 风险、跨对象类型、项目成员与 `OWNER / REVIEWER` 角色推导建议审查人、审查原因、风险类型和 warning；缺成员或缺角色时 fail-closed 给 warning，不虚构 reviewer，不写 approval，不自动 assign。C1 已实现 message、`proposed_items` extraction、ChangeSet detail、ChangeItem `accept/edit/defer`；C2 backend/frontend 已实现 `POST /pmflow-os/change-sets/{change_set_id}/commit` 与真实模式前端接入，默认 atomic，将 `Requirement / Decision / Risk` 写入 `truth_nodes`，将 `Task` 写入 `truth_nodes(node_type='task') + tasks`，高风险项强制 approval gate；D.2 已实现 `POST /pmflow-os/projects/{project_id}/execution-handoffs`，校验 task/repo project 边界，生成/复用 `PromptPackage(package_kind='execution_handoff')` 并写 `ProgressEvent(event_type='handoff_created')` 起点；P1 已实现 `POST /pmflow-os/projects/{project_id}/execution-handoffs/{prompt_package_id}/consume`，校验 execution handoff package 后更新 `PromptPackage.package_payload.latest_handoff.handoff_state=consumed` 并写 `ProgressEvent(event_type='handoff_consumed', derived_task_status='coding')`；Release Growth P1 在 `ExecutionSummaryProjection.releaseGate` 中从 `ProgressEvent` 推导发布门禁状态，失败事件 fail-closed 阻塞发布，无证据返回 empty/warning；Release Validation P1 新增 `POST /pmflow-os/projects/{project_id}/release-validation-runs`，复用现有 `ReleaseValidationRun` 模型固化当前 `releaseGate` 快照、人工决策、证据、阻塞原因和下一步动作，并在 `releaseGate.latestValidationRun` 返回最新记录；Release Feedback P1 新增 `POST /pmflow-os/projects/{project_id}/release-feedback-ingests`，复用现有 `FeedbackIngest / IterationRecommendation`，在 `ExecutionSummaryProjection.releaseSignals` 中返回真实发布后 feedback、revenue event 和 iteration recommendation 读模型；Iteration Loop P1 新增 `POST /pmflow-os/projects/{project_id}/iteration-recommendations/{recommendation_id}/change-set-drafts`，把真实 recommendation 转为 open ChangeSet、pending_review Requirement/Task/Risk/Decision items 与 `iteration_recommendation` evidence，重复调用复用既有 draft 并在 `releaseSignals` 标记 `changeSetCreated/changeSetId`；这些步骤都不直接执行本机命令、真实发布命令、外部支付、真实推送、自动 Project Memory commit 或正式任务创建；`ModelDecision / MetricSignal` 在 C2 V1 仍 fail-closed。 - PMFlow Launch 后端 Phase B 创建链位于 `backend/app/api/pmflow_launch_api/`、`backend/app/services/pmflow_launch_service.py`、`backend/app/schemas/pmflow_launch.py` 与 `backend/app/models/pmflow_launch.py`；`POST /pmflow-launch/drafts` 只写 `pmflow_launch_drafts`，`POST /pmflow-launch/drafts/{draft_id}/confirm` 在同一事务内写 `projects / user_projects / pmflow_threads / pmflow_thread_messages / truth_nodes / tasks / semantic_facts seed / operation_logs`，并把 `launch_draft_id / thread_id / thread_message_id` 写入正式对象 metadata。 - `frontend/src/features/pmflow-os/components/ChangeReviewGroup.tsx`、`WorkbenchPanel.tsx`、`ExecutionBridgeCards.tsx`、`PMFlowOsFrame.tsx`、`AccountControls.tsx`、`FeedbackPrimitives.tsx` 是高保真原型新增的行为组件层：分别承载变更 diff 审查块、工作台对象卡组、执行桥上下文/日志卡片、全局上下文条与 AI 副驾、账号菜单/退出登录确认交互，以及 `PageBanner / InlineNotice / HumanDecisionBar / ConfirmDialog / MobileBottomSheet` 这组提示、提醒、确认与移动端 bottom sheet 基础组件，避免再把这些业务片段内联塞回 `pages/`。 - `frontend/vite.config.ts` 现补了固定 vendor chunk 分组（`framework / state-query / ui-radix / icons / charts / markdown`）与业务 chunk 分组（`ai-steward / sstc / governance`），目标是让登录页与基础导航不再背 AI Steward、SSTC、治理页和图表代码。 diff --git a/docs/architecture/CODE_REFERENCE_INDEX.md b/docs/architecture/CODE_REFERENCE_INDEX.md index 54bcf480..3ae0ae29 100644 --- a/docs/architecture/CODE_REFERENCE_INDEX.md +++ b/docs/architecture/CODE_REFERENCE_INDEX.md @@ -89,7 +89,7 @@ - SSTC 负责人推荐接口：参考 `POST /projects/{project_id}/tasks/{task_id}/recommend-assignee` - SSTC 任务更新接口：参考 `PATCH /projects/{project_id}/tasks/{task_id}` - SSTC 发布创建接口：参考 `POST /projects/{project_id}/releases` -- PMFlow OS 真实读路径、C1 Change Review API、C2 backend commit、Execution Handoff、Release Evidence Gate、Release Validation Run、Release Feedback Signal 与 Iteration Loop draft：参考 `backend/app/api/pmflow_os_api/`、`backend/app/services/pmflow_os_projection_service.py`、`backend/app/services/pmflow_change_review_service.py`、`backend/app/schemas/pmflow_os.py`；只读提供 `GET /pmflow-os/projects/{project_id}/truth-state` 与 `GET /pmflow-os/projects/{project_id}/execution-summary`，复用 `truth_nodes / tasks / semantic_facts / ai_project_control / dev_sync`，并读取 `pmflow_threads / pmflow_thread_messages / pmflow_change_sets / pmflow_change_items / pmflow_approvals / pmflow_evidence_links`；C1 写 API 包括 thread message、`proposed_items` extraction、ChangeSet detail、ChangeItem `accept/edit/defer`；C2 backend 已实现 `POST /pmflow-os/change-sets/{change_set_id}/commit`，默认 `mode=atomic`，将 `Requirement / Decision / Risk` 写入 `truth_nodes`，将 `Task` 写入 `truth_nodes(node_type='task') + tasks`，高风险项强制 approval gate；D.2 已实现 `POST /pmflow-os/projects/{project_id}/execution-handoffs`，对已确认任务生成/复用 `PromptPackage` 并创建 `ProgressEvent(event_type='handoff_created')` 起点；P1 已实现 `POST /pmflow-os/projects/{project_id}/execution-handoffs/{prompt_package_id}/consume`，记录运行端领取、更新 `PromptPackage.package_payload.latest_handoff.handoff_state=consumed` 并创建 `ProgressEvent(event_type='handoff_consumed', derived_task_status='coding')`；Release Growth P1 已在 `execution-summary.releaseGate` 中从 branch / commit / PR / test_passed / checks_passed / failed / blocked 等 `ProgressEvent` 推导 `ready / blocked / needs_confirmation / empty`；Release Validation P1 新增 `POST /pmflow-os/projects/{project_id}/release-validation-runs`，从当前 `releaseGate` 固化 `ReleaseValidationRun` 快照并在 `releaseGate.latestValidationRun` 返回最新记录，无 evidence 时返回 `release_validation_evidence_empty`；Release Feedback P1 新增 `POST /pmflow-os/projects/{project_id}/release-feedback-ingests`，复用 `FeedbackIngest / IterationRecommendation` 写入真实发布后反馈，并在 `execution-summary.releaseSignals` 投影真实 `feedback / revenueEvents / recommendations` 与 release gate / validation run 关系；Iteration Loop P1 新增 `POST /pmflow-os/projects/{project_id}/iteration-recommendations/{recommendation_id}/change-set-drafts`，把真实 `IterationRecommendation` 转为 open ChangeSet、pending_review Requirement/Task/Risk/Decision items 与 iteration evidence，重复调用复用既有 draft；这些步骤均不执行发布命令、外部支付、真实推送或自动 Project Memory commit +- PMFlow OS 真实读路径、C1 Change Review API、C2 backend commit、Execution Handoff、Release Evidence Gate、Release Validation Run、Release Feedback Signal、Iteration Loop draft 与 Team reviewer routing：参考 `backend/app/api/pmflow_os_api/`、`backend/app/services/pmflow_os_projection_service.py`、`backend/app/services/pmflow_change_review_service.py`、`backend/app/schemas/pmflow_os.py`；只读提供 `GET /pmflow-os/projects/{project_id}/truth-state` 与 `GET /pmflow-os/projects/{project_id}/execution-summary`，复用 `truth_nodes / tasks / semantic_facts / ai_project_control / dev_sync`，并读取 `pmflow_threads / pmflow_thread_messages / pmflow_change_sets / pmflow_change_items / pmflow_approvals / pmflow_evidence_links`；`truth-state.reviewerRouting` 会从 open/pending ChangeSet、待审 item 风险、跨对象类型、项目成员与 `OWNER / REVIEWER` 角色生成建议审查人、审查原因、风险类型和 warning，只读展示，不写 approval、不自动 assign reviewer；C1 写 API 包括 thread message、`proposed_items` extraction、ChangeSet detail、ChangeItem `accept/edit/defer`；C2 backend 已实现 `POST /pmflow-os/change-sets/{change_set_id}/commit`，默认 `mode=atomic`，将 `Requirement / Decision / Risk` 写入 `truth_nodes`，将 `Task` 写入 `truth_nodes(node_type='task') + tasks`，高风险项强制 approval gate；D.2 已实现 `POST /pmflow-os/projects/{project_id}/execution-handoffs`，对已确认任务生成/复用 `PromptPackage` 并创建 `ProgressEvent(event_type='handoff_created')` 起点；P1 已实现 `POST /pmflow-os/projects/{project_id}/execution-handoffs/{prompt_package_id}/consume`，记录运行端领取、更新 `PromptPackage.package_payload.latest_handoff.handoff_state=consumed` 并创建 `ProgressEvent(event_type='handoff_consumed', derived_task_status='coding')`；Release Growth P1 已在 `execution-summary.releaseGate` 中从 branch / commit / PR / test_passed / checks_passed / failed / blocked 等 `ProgressEvent` 推导 `ready / blocked / needs_confirmation / empty`；Release Validation P1 新增 `POST /pmflow-os/projects/{project_id}/release-validation-runs`，从当前 `releaseGate` 固化 `ReleaseValidationRun` 快照并在 `releaseGate.latestValidationRun` 返回最新记录，无 evidence 时返回 `release_validation_evidence_empty`；Release Feedback P1 新增 `POST /pmflow-os/projects/{project_id}/release-feedback-ingests`，复用 `FeedbackIngest / IterationRecommendation` 写入真实发布后反馈，并在 `execution-summary.releaseSignals` 投影真实 `feedback / revenueEvents / recommendations` 与 release gate / validation run 关系；Iteration Loop P1 新增 `POST /pmflow-os/projects/{project_id}/iteration-recommendations/{recommendation_id}/change-set-drafts`，把真实 `IterationRecommendation` 转为 open ChangeSet、pending_review Requirement/Task/Risk/Decision items 与 iteration evidence，重复调用复用既有 draft；这些步骤均不执行发布命令、外部支付、真实推送或自动 Project Memory commit - Project Launch 真实创建链：参考 `backend/app/api/pmflow_launch_api/`、`backend/app/services/pmflow_launch_service.py`、`backend/app/schemas/pmflow_launch.py` 与模型 `backend/app/models/pmflow_launch.py`；接口为 `POST /pmflow-launch/drafts` 与 `POST /pmflow-launch/drafts/{draft_id}/confirm`，draft 只写 `pmflow_launch_drafts`，confirm 在同一事务内创建 `projects / user_projects / pmflow_threads / pmflow_thread_messages / truth_nodes / tasks / semantic_facts seed / operation_logs` - PMFlow Change Review 模型与 migration：参考 `backend/app/models/pmflow_change_review.py` 与 `backend/alembic/versions/20260426_add_pmflow_change_review_tables.py`；只包含 `pmflow_change_sets / pmflow_change_items / pmflow_approvals / pmflow_evidence_links`，本阶段不得新增或依赖 `/commit` @@ -108,7 +108,7 @@ - 新项目启动台 / 首次进入页前端产品域：参考 `frontend/src/features/project-launch/` 与薄入口 `frontend/src/pages/ProjectLaunchPage.tsx`；真实模式默认通过 `frontend/src/api/pmflowLaunch.ts` 调用后端 draft/confirm API，只有显式 `?demo=1` 或 `?dataSource=demo` 才启用 `mockData.ts` 本地演示状态机；本地预览路由入口为 `/project-launch` - Account Settings / `/me` 前端产品域与 P1/P2/P3/P5/P6 偏好合同：参考 `frontend/src/features/account-settings/AccountSettingsPanel.tsx`、`frontend/src/features/pmflow-os/pages/AccountPage.tsx`、`frontend/src/api/accountSettings.ts`、`backend/app/api/account_settings_api/`、`backend/app/schemas/account_settings.py` 与 `backend/app/services/account_settings_service.py`；当前覆盖个人资料、默认语言、AI 回答深度、证据展示偏好、待确认、执行回写、发布门禁和失败提醒通知偏好，移动端使用分组列表与 bottom sheet，账户退出仍复用 `AccountControls.tsx`，不改 OAuth/JWT/auth core；P1 后端合同提供 `GET /account-settings/me` 与 `PUT /account-settings/me`，已由 `backend/app/api/router.py` 挂入核心路由组，按当前 `tenant_id + user_id` 保存账号偏好，前端有 token 时优先账号同步，后端不可用时明确回落 `仅本机暂存 / 保存失败`；P2 在 `frontend/src/api/accountSettings.ts` 提供 `shouldShowAccountNotification` 与 `getAccountNotificationConsumption`，把通知偏好映射为页面内提醒消费模型；P3 新增 `getReleaseGateNotificationPreference(settings, event)` 供 Release/Growth 后续消费：`release_gate_*` 与 `release_validation_*` 使用 `releaseGate` 偏好，`failed_event` 使用 `failureAlert` 偏好；P5/P6 的 `getPostReleaseNotificationPreference(settings, event)` 供发布后反馈与下一轮待确认消费：`feedback_received / revenue_signal / compliance_blocked` 使用 `releaseGate` 偏好，`iteration_recommendation / next_change_review` 使用 `pendingConfirmation` 偏好并落到 `change_review` surface，返回 `spaceReadable / showInAppReminder / evidencePolicy / reminderPolicy`；ReleaseGrowthPage 当前消费 `releaseGate` 与 `failureAlert` 两个偏好，只静默强调型提醒，不隐藏 release evidence、阻塞原因、审计状态、validation run、releaseSignals 或下一轮 ChangeSet draft；这些 helper 只控制本地 UI 提醒消费合同，不代表真实邮件、桌面推送或系统通知中心已接入 - PMFlow OS 共享 truth store 与主链状态动作：参考 `frontend/src/features/pmflow-os/store.tsx`；当前支持 `?projectId=` 走 React Query 读取真实 `truth-state` 与 `execution-summary`，真实模式下 thread message、`proposed_items` extraction、ChangeItem `accept/edit/defer`、ChangeSet commit、Execution Handoff create/consume、execution progress writeback、release validation run create、release feedback ingest 与 iteration recommendation -> ChangeSet draft 均调后端并 refetch，不本地 promote 入 Project Memory、不伪造 execution event、发布验证记录、发布后信号或下一轮 draft；`?demo=1` 才启用本地 mock 演示状态机和本地动作；项目内 AI 结构化闭环状态机为 `command_idle / ai_extracting / extraction_ready / review_open / writeback_success` -- PMFlow OS 产品页入口：参考 `frontend/src/features/pmflow-os/pages/CommandCenterPage.tsx`、`StructuredExtractionPage.tsx`、`ChangeReviewPage.tsx`、`MemoryWritebackResultPage.tsx`、`WorkGraphPage.tsx`、`ExecutionBridgePage.tsx`、`ReleaseGrowthPage.tsx`、`TeamLayerPage.tsx`、`ProjectMemoryPage.tsx`、`AccountPage.tsx`；`ReleaseGrowthPage.tsx` 真实模式展示 `execution-summary.releaseGate`、execution evidence、阻塞原因、下一步动作、`latestValidationRun` 和 `releaseSignals`，缺证据或缺发布后信号时显示 empty/warning，不展示 mock 发布结果；页面可调用真实 API 创建 release validation run、摄取 release feedback，并从真实 recommendation 生成下一轮待确认 ChangeSet draft，生成后仍进入 Change Review accept/edit/defer，不自动 commit、不写 Project Memory、不执行部署命令、不接外部支付；同时消费 Account notification preference helper，`releaseGate` 关闭时静默发布门禁强调提醒，`failureAlert` 关闭时静默失败强调提醒，所有真实证据和审计状态仍可见；静态高保真发布/增长数据仅保留在显式 demo 模式 +- PMFlow OS 产品页入口：参考 `frontend/src/features/pmflow-os/pages/CommandCenterPage.tsx`、`StructuredExtractionPage.tsx`、`ChangeReviewPage.tsx`、`MemoryWritebackResultPage.tsx`、`WorkGraphPage.tsx`、`ExecutionBridgePage.tsx`、`ReleaseGrowthPage.tsx`、`TeamLayerPage.tsx`、`ProjectMemoryPage.tsx`、`AccountPage.tsx`；`TeamLayerPage.tsx` 真实模式读取 `state.reviewerRouting` 展示待审 ChangeSet、建议审查人、审查原因、风险类型和缺角色 warning，动作只跳转 Change Review，不自动分派 reviewer；`ReleaseGrowthPage.tsx` 真实模式展示 `execution-summary.releaseGate`、execution evidence、阻塞原因、下一步动作、`latestValidationRun` 和 `releaseSignals`，缺证据或缺发布后信号时显示 empty/warning，不展示 mock 发布结果；页面可调用真实 API 创建 release validation run、摄取 release feedback，并从真实 recommendation 生成下一轮待确认 ChangeSet draft，生成后仍进入 Change Review accept/edit/defer，不自动 commit、不写 Project Memory、不执行部署命令、不接外部支付；同时消费 Account notification preference helper，`releaseGate` 关闭时静默发布门禁强调提醒，`failureAlert` 关闭时静默失败强调提醒，所有真实证据和审计状态仍可见；静态高保真发布/增长数据仅保留在显式 demo 模式 - PMFlow OS 行为组件：参考 `frontend/src/features/pmflow-os/components/ProjectStructuredLoop.tsx`、`ProjectStageRail.tsx`、`ThreadComposer.tsx`、`ExtractionRail.tsx`、`ChangeGroupPanel.tsx`、`ObjectGraphSection.tsx`、`ContextPacketPanel.tsx`、`ExecutionTimeline.tsx`、`ReleaseGatePanel.tsx`、`TeamFeedPanel.tsx`、`ChangeReviewGroup.tsx`、`WorkbenchPanel.tsx`、`ExecutionBridgeCards.tsx`、`PMFlowOsFrame.tsx`、`AccountControls.tsx`、`FeedbackPrimitives.tsx`、`MobileBottomNav.tsx`；其中 `ProjectStructuredLoop.tsx` 承接 `StatusLabel / EvidenceSnippet / ObjectChangeCard / ProjectConversationPanel / StructuredExtractionPanel / ProjectAICopilotPanel`，`PMFlowOsFrame.tsx` 承接项目内面包屑和项目切换器，`AccountControls.tsx` 承接桌面头像菜单、退出登录确认与移动端 bottom sheet，`FeedbackPrimitives.tsx` 承接 `PageBanner / InlineNotice / HumanDecisionBar / ConfirmDialog / MobileBottomSheet`，`MobileBottomNav.tsx` 承接正式应用壳移动端固定底部导航 - PMFlow OS 原型状态回归测试：参考 `frontend/src/features/pmflow-os/store.test.ts`；真实 API 动作回归参考 `frontend/src/features/pmflow-os/store.api.test.tsx` - Project Launch 真实/演示分支回归测试：参考 `frontend/src/features/project-launch/useProjectLaunchState.test.ts` diff --git a/frontend/src/api/pmflowOs.ts b/frontend/src/api/pmflowOs.ts index d37d4fff..5d246bf9 100644 --- a/frontend/src/api/pmflowOs.ts +++ b/frontend/src/api/pmflowOs.ts @@ -239,6 +239,26 @@ export interface PMFlowIterationRecommendationChangeSetDraftResult { warnings: string[]; } +export interface PMFlowReviewerSuggestion { + userId: string; + name: string; + role: string; + reason: string; +} + +export interface PMFlowChangeSetReviewerRouting { + changeSetId: string; + headline: string; + summary: string; + pendingItemCount: number; + highestRiskLevel: PMFlowRiskLevel; + riskTypes: string[]; + crossDomain: boolean; + suggestedReviewers: PMFlowReviewerSuggestion[]; + reviewReasons: string[]; + warning?: string | null; +} + export interface PMFlowExecutionHandoffRequest { task_id: string; repo_binding_id?: string | null; diff --git a/frontend/src/features/pmflow-os/pages/TeamLayerPage.tsx b/frontend/src/features/pmflow-os/pages/TeamLayerPage.tsx index e5173058..991e84f9 100644 --- a/frontend/src/features/pmflow-os/pages/TeamLayerPage.tsx +++ b/frontend/src/features/pmflow-os/pages/TeamLayerPage.tsx @@ -17,6 +17,10 @@ import { TrendingUp, X, } from "lucide-react"; +import { useNavigate } from "react-router-dom"; +import type { PMFlowChangeSetReviewerRouting } from "@/api/pmflowOs"; +import { usePMFlowOsStore } from "@/features/pmflow-os/store"; +import type { PMFlowRiskLevel, ProjectTruthState } from "@/features/pmflow-os/types"; import { cn } from "@/lib/utils"; const activityItems = [ @@ -49,10 +53,27 @@ const agentCards = [ ] as const; export default function TeamLayerPage() { + const navigate = useNavigate(); + const { state, openReview, projectionWarnings } = usePMFlowOsStore(); + const reviewerRouting = + (state as ProjectTruthState & { reviewerRouting?: PMFlowChangeSetReviewerRouting[] }).reviewerRouting || []; + const pendingReviewCount = state.changeItems.filter((item) => item.status === "pending_review").length; + const reviewerWarnings = projectionWarnings.filter((warning) => warning.includes("reviewer_routing_warning")); + const handleOpenReview = (changeSetId: string) => { + openReview(changeSetId); + navigate("/change-review"); + }; + return (
+
@@ -68,6 +89,114 @@ export default function TeamLayerPage() { ); } +function ReviewerRoutingPanel({ + pendingReviewCount, + routings, + warnings, + onOpenReview, +}: { + pendingReviewCount: number; + routings: PMFlowChangeSetReviewerRouting[]; + warnings: string[]; + onOpenReview: (changeSetId: string) => void; +}) { + const visibleRoutings = routings.slice(0, 3); + return ( + +
+
+
+ + 审查路由 +
+

待审 ChangeSet 审查路由

+

+ 基于项目成员角色、待审变更风险和跨对象影响生成建议审查人；这里只展示建议，不自动分派审查人。 +

+
+
+ + + +
+
+ {visibleRoutings.length > 0 ? ( +
+ {visibleRoutings.map((routing) => ( +
+
+
+
+ + {riskLabel(routing.highestRiskLevel)} + + {routing.crossDomain ? 跨域 : null} +
+

{routing.headline}

+

{routing.summary}

+
+ +
+
+ {routing.riskTypes.map((type) => ( + + {type} + + ))} +
+
+
建议审查人
+ {routing.suggestedReviewers.length > 0 ? ( + routing.suggestedReviewers.map((reviewer) => ( +
+
+ {reviewer.name} + {reviewer.role} +
+

{reviewer.reason}

+
+ )) + ) : ( +
+ {routing.warning || "缺少可用审查人，暂不虚构建议人。"} +
+ )} +
+
+
审查原因
+ {routing.reviewReasons.map((reason) => ( +

+ {reason} +

+ ))} +
+
+ ))} +
+ ) : ( +
+ 当前没有待审 ChangeSet 审查路由。若后端缺成员或缺 OWNER / REVIEWER 角色，会在这里显示警告，不会补假审查人。 +
+ )} + + ); +} + +function MetricPill({ label, value }: { label: string; value: string }) { + return ( +
+
{label}
+
{value}
+
+ ); +} + function TeamActivityPanel() { return ( @@ -310,3 +439,15 @@ function iconTone(tone: string) { if (tone === "warning") return "bg-orange-500"; return "bg-[#2463EB]"; } + +function riskLabel(level: PMFlowRiskLevel) { + if (level === "high") return "高风险"; + if (level === "medium") return "中风险"; + return "低风险"; +} + +function riskTone(level: PMFlowRiskLevel) { + if (level === "high") return "bg-red-50 text-red-600"; + if (level === "medium") return "bg-orange-50 text-orange-600"; + return "bg-emerald-50 text-emerald-600"; +} diff --git a/frontend/src/features/pmflow-os/store.api.test.tsx b/frontend/src/features/pmflow-os/store.api.test.tsx index 6c8fbf04..da4b9f3c 100644 --- a/frontend/src/features/pmflow-os/store.api.test.tsx +++ b/frontend/src/features/pmflow-os/store.api.test.tsx @@ -1,6 +1,7 @@ import { QueryClient, QueryClientProvider } from "@tanstack/react-query"; import { act, cleanup, fireEvent, render, renderHook, screen, waitFor } from "@testing-library/react"; import type { ReactNode } from "react"; +import { MemoryRouter } from "react-router-dom"; import { afterEach, beforeEach, describe, expect, it, vi } from "vitest"; import { getAccountSettings } from "@/api/accountSettings"; @@ -18,10 +19,12 @@ import { editPMFlowChangeItem, getPMFlowExecutionSummary, getPMFlowTruthState, + type PMFlowChangeSetReviewerRouting, type PMFlowExecutionSummary, type PMFlowReleaseGate, } from "@/api/pmflowOs"; import { createInitialPMFlowState } from "@/features/pmflow-os/mockData"; +import TeamLayerPage from "@/features/pmflow-os/pages/TeamLayerPage"; import { PMFlowOsProvider, usePMFlowOsStore } from "@/features/pmflow-os/store"; import type { ProjectTruthState } from "@/features/pmflow-os/types"; @@ -112,6 +115,27 @@ function realState(): ProjectTruthState { sourceLabel: "项目线程", }, ]; + (state as ProjectTruthState & { reviewerRouting: PMFlowChangeSetReviewerRouting[] }).reviewerRouting = [ + { + changeSetId: "11", + headline: "真实变更集", + summary: "高风险跨域变更待审", + pendingItemCount: 1, + highestRiskLevel: "high", + riskTypes: ["高风险", "跨对象：Risk / Task"], + crossDomain: true, + suggestedReviewers: [ + { + userId: "9", + name: "审查负责人", + role: "REVIEWER", + reason: "REVIEWER 角色，优先复核 high risk 变更。", + }, + ], + reviewReasons: ["1 个变更项仍处于待审状态。", "包含 high risk 变更，需要 REVIEWER 或 OWNER 复核。"], + warning: null, + }, + ]; return state; } @@ -462,6 +486,24 @@ describe("PMFlowOsProvider real change review actions", () => { vi.clearAllMocks(); }); + it("renders reviewer routing on team layer without assigning reviewers", async () => { + render( + + + , + { wrapper: wrapper() } + ); + + expect(await screen.findByText("待审 ChangeSet 审查路由")).toBeInTheDocument(); + expect(await screen.findByText("真实变更集")).toBeInTheDocument(); + expect(screen.getByText("审查负责人")).toBeInTheDocument(); + expect(screen.getByText("REVIEWER")).toBeInTheDocument(); + expect(screen.getByText("跨域")).toBeInTheDocument(); + fireEvent.click(screen.getByRole("button", { name: /去审查/ })); + expect(acceptItemMock).not.toHaveBeenCalled(); + expect(commitChangeSetMock).not.toHaveBeenCalled(); + }); + it("calls real message and review APIs in api mode and does not locally promote to project memory", async () => { const { result } = renderHook(() => usePMFlowOsStore(), { wrapper: wrapper() });